Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGINT properly in the ros2_control_node #2014

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

Related to #2012

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (d4139b7) to head (c11211b).

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
+ Coverage   89.38%   89.45%   +0.07%     
==========================================
  Files         132      132              
  Lines       14663    14688      +25     
  Branches     1258     1265       +7     
==========================================
+ Hits        13106    13139      +33     
+ Misses       1090     1085       -5     
+ Partials      467      464       -3     
Flag Coverage Δ
unittests 89.45% <96.87%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 100.00% <ø> (ø)
controller_manager/src/controller_manager.cpp 76.58% <100.00%> (+0.30%) ⬆️
...ller_manager/test/test_ros2_control_node_launch.py 100.00% <100.00%> (ø)
hardware_interface/src/resource_manager.cpp 75.65% <100.00%> (+0.62%) ⬆️
controller_manager/src/ros2_control_node.cpp 62.50% <91.66%> (+0.68%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant