Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to extract points from rasters #91

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ThierryO
Copy link
Member

No description provided.

@stijnvanhoey
Copy link
Collaborator

Thanks a lot for the contribution; being able to query radar rainfall (and other spatial products?) is a long standing open issue, see #51 (and wrapping GetRasterToPointValues is probably the most usefule of the calls enlisted in the issue).

@damianooldoni or @peterdesmet are you able to review the R-implementation? (there is some syntax I am not really up to date with to properly review)

(I am on holiday for the moment and won't be able to further check till half August, so @peterdesmet feel free to merge if all fine).

@stijnvanhoey
Copy link
Collaborator

Before we forget, @ThierryO please enlist the new function in the pkgdown overview file (which we manage manually to help users find the most important functions), https://github.com/ropensci/wateRinfo/blob/master/_pkgdown.yml#L23 I think this one belongs to the main/first section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants