Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Disable historical_weather() #142

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: bomrang
Type: Package
Title: Australian Government Bureau of Meteorology ('BOM') Data Client
Version: 0.7.4.9000
Version: 0.7.4.9001
Authors@R:
c(person(given = "Adam H.",
family = "Sparks",
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# bomrang (development version)

# bomrang 0.7.5

* `get_historical_weather()` has been disabled due to changes by BOM. See https://github.com/ropensci/bomrang/discussions/141

# bomrang 0.7.4

## Bug fixes
Expand Down
9 changes: 8 additions & 1 deletion R/get_historical_weather.R
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@
#' @author Jonathan Carroll, \email{rpkg@@jcarroll.com.au}
#'
#' @examples
#' \donttest{
#' \dontrun{
#' ## these are currently not functional due to BOM changes
#' get_historical_weather(stationid = "023000",
#' type = "max") ## ~48,000+ daily records
#' get_historical_weather(latlon = c(-35.2809, 149.1300),
Expand All @@ -101,6 +102,12 @@ get_historical_weather <- get_historical <-
latlon = NULL,
radius = NULL,
type = c("rain", "min", "max", "solar")) {

stop("Due to recent changes by the BOM, this functionality is temporarily disabled.
Refer to http://reg.bom.gov.au/other/copyright.shtml
and
https://github.com/ropensci/bomrang/discussions/141")

site <- ncc_obs_code <- NULL #nocov

if (is.null(stationid) & is.null(latlon))
Expand Down