Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Use enqueue_block_assets for editor assets #3196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔧 Use enqueue_block_assets for editor assets #3196

wants to merge 1 commit into from

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Sep 19, 2024

This PR fixes the following warning:

editor/0-css was added to the iframe incorrectly. Please use block.json or enqueue_block_assets to add styles to the iframe.

Ref #3185

@retlehs retlehs self-assigned this Sep 19, 2024
@github-actions github-actions bot added the php Pull requests that update PHP code label Sep 19, 2024
imre08
imre08 reviewed Oct 23, 2024
View reviewed changes
Copy link

@imre08 imre08 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the block editor assets, namely css are not loaded anymore, when using this action.

I am using WordPress 6.6.2 with Sage and Acorn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imre08 imre08 imre08 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@retlehs retlehs

Labels
php Pull requests that update PHP code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retlehs @imre08