-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for https://github.com/root-project/root/issues/13574 #1030
base: master
Are you sure you want to change the base?
Conversation
Starting build on |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
Build failed on mac12arm/cxx20. Failing tests: |
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Build failed on windows10/default. Failing tests: |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Build failed on mac12arm/cxx20. Failing tests: |
Build failed on windows10/default. Errors:
And 12 more |
Starting build on |
Build failed on windows10/default. Failing tests: |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Build failed on mac12arm/cxx20. Failing tests: |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Build failed on windows10/default. Failing tests: |
Starting build on |
@phsft-bot build |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Build failed on mac12arm/cxx20. Failing tests: |
Starting build on |
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Starting build on |
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
Build failed on mac12arm/cxx20. Failing tests: |
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall changes look good, but I have some minor comments for discussion before approving
It needs to be 'version' without a trailing s
Need to have a comma separated list of version specifiers or a version range (eg `4-`) enclosed in *square brackets*.
@phsft-bot build |
Starting build on |
@phsft-bot build |
Starting build on |
See root-project/root#13574