[Python][Hist] Add extra checks for the vectorized fill #20704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
reviewed
Dec 12, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks! Can we add the unittest with the constructor accepting the string on the Python side too?
vepadulano
approved these changes
Dec 12, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge once the CI is green.
Test Results 20 files 20 suites 3d 10h 3m 22s ⏱️ Results for commit 0c731be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #20597 (comment)