[hist] Remove CINT compatibility constructors from TF1, THF2, and TF3 #20702
+1
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TF1`, `TF2`, and `TF3` constructors for CINT compatibility can be removed. This concerns the templated constructors that additionally took the name of the used functor class and member function. With ROOT 6, these names can be omitted. See also commit 4e4cdfb from 2015, where these constructors were introduced. The idea is to clear a bit more the jungle of `TH1` constructors, of which there are too many. That makes it confusing for our uses and for cppyy overload resolution.
Test Results 21 files 21 suites 3d 20h 56m 45s ⏱️ Results for commit 3e94437. |
pcanal
reviewed
Dec 11, 2025
|
|
||
| // backward compatible interface | ||
| template <typename Func> | ||
| TF1(const char *name, Func f, Double_t xmin, Double_t xmax, Int_t npar, const char *, EAddToList addToGlobList = EAddToList::kDefault) : |
Member
There was a problem hiding this comment.
Should we deprecate them first or are we sure they were only use by/via CINT?
Contributor
Author
There was a problem hiding this comment.
I don't see why anyone would use these constructors otherwise, as it's not needed in C++ to pass the name of the class instance Func as a separate argument.
The reason why I think we can remove it without deprecation is that the replacement is trivial and backwards compatible: just drop these const char* inputs at the end. But if you're more comfortable with a deprecation period, I have no problem.
Maybe @lmoneta also has a opinion there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TF1,TF2, andTF3constructors for CINT compatibility can be removed. This concerns the templated constructors that additionally took the name of the used functor class and member function. With ROOT 6, these names can be omitted.See also commit 4e4cdfb from 2015, where these constructors were introduced.
The idea is to clear a bit more the jungle of
TH1constructors, of which there are too many. That makes it confusing for our uses and for cppyy overload resolution.