Skip to content

Remove tutorials requiring py-hsimple.root from wheel tests #20689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vepadulano merged 1 commit into from
Dec 12, 2025
Merged

Remove tutorials requiring py-hsimple.root from wheel tests #20689

vepadulano merged 1 commit into from
Dec 12, 2025
+2 −0

Conversation

@vepadulano
Copy link
Member

@vepadulano vepadulano commented Dec 11, 2025

No description provided.

@vepadulano vepadulano self-assigned this Dec 11, 2025
@vepadulano vepadulano requested a review from dpiparo as a code owner December 11, 2025 08:08
@vepadulano vepadulano added in:Build System skip ci Skip the full builds on the actions runners build-python-wheels Run the workflow to build Python wheels labels Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Dec 11, 2025 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 488cfe3.

♻️ This comment has been updated with latest results.

hahnjo
hahnjo approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siliataider
Copy link
Contributor

siliataider commented Dec 11, 2025

So these 2 tutorials are failing because the file needed is created by tutorials/hsimple.py which is not run, maybe we should just run it instead of disabling them?

@vepadulano vepadulano force-pushed the wheel-test-remove-hist015 branch from d69b096 to 0048689 Compare December 11, 2025 14:36
@vepadulano vepadulano changed the title [build] Skip test requiring hsimple file Run hsimple.py tutorial first to produce needed file Dec 11, 2025
@vepadulano vepadulano force-pushed the wheel-test-remove-hist015 branch from 0048689 to 0aa60e5 Compare December 11, 2025 16:46
@vepadulano
Copy link
Member Author

vepadulano commented Dec 12, 2025

So these 2 tutorials are failing because the file needed is created by tutorials/hsimple.py which is not run, maybe we should just run it instead of disabling them?

Even after running the hsimple.py tutorial before the other tutorials, the file is still not found. In the interest of returning the CI to a working state, I will go back to removing the tutorials and then we can tackle this another time.

@vepadulano vepadulano force-pushed the wheel-test-remove-hist015 branch from 0aa60e5 to 488cfe3 Compare December 12, 2025 07:25
@vepadulano vepadulano changed the title Run hsimple.py tutorial first to produce needed file Remove tutorials requiring py-hsimple.root from wheel tests Dec 12, 2025
guitargeek
guitargeek approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vepadulano vepadulano merged commit c591107 into root-project:master Dec 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnjo hahnjo hahnjo approved these changes

@guitargeek guitargeek guitargeek approved these changes

@siliataider siliataider siliataider approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@vepadulano vepadulano

Labels

build-python-wheels Run the workflow to build Python wheels in:Build System skip ci Skip the full builds on the actions runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vepadulano @siliataider @hahnjo @guitargeek