[RF][HF] Move all classes for Measurement specification to Measurement.h #20500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
hf_header_collaple
branch
from
96c1115 to
fe239d4
Compare
Test Results 22 files 22 suites 3d 18h 3m 29s ⏱️ Results for commit fe239d4. |
The Measurement uses several other helper classes, which are scattered
in different header and implementation files.
Merging these classes to one header and compilation unit has several
advantages:
* User only needs to include one header
* Easier to get an overview on the structure of the Measurement class,
which helps for refactoring and re-designing of HistFactor using the
new ROOT histogram classes
* Shorter compilation times
There is no breaking of backwards compatibility, as the old header files
are all kept around, just with no content. However, the headers are
clearly deprecated with a warning that they are going to be removed in
ROOT 7.
guitargeek
force-pushed
the
hf_header_collaple
branch
from
fe239d4 to
5eaa974
Compare
lmoneta
approved these changes
Dec 11, 2025
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thanks Jonas for the improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Measurement uses several other helper classes, which are scattered in different header and implementation files.
Merging these classes to one header and compilation unit has several advantages:
User only needs to include one header
Easier to get an overview on the structure of the Measurement class, which helps for refactoring and re-designing of HistFactor using the new ROOT histogram classes
Shorter compilation times
There is no breaking of backwards compatibility, as the old header files are all kept around, just with no content. However, the headers are clearly deprecated with a warning that they are going to be removed in ROOT 7.