[CPyCppyy] Add smart pointer conversion policy flag and remove local memory heuristics flag #19660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files 20 suites 3d 16h 45m 53s ⏱️ For more details on these failures, see this check. Results for commit f3c618a. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Aug 25, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM, but I would indeed wait for the followup on wlav/CPyCppyy#63
Steering the memory policy locally at the level of methods and functions is redundant, because one can always define pythonizations that take care of that. Removing this feature allows us to add new policy flags without increasing the net complexity of the library.
guitargeek
force-pushed
the
mempolicy
branch
from
f3c618a to
745e365
Compare
Contributor
Author
|
The upstream review has not happened yet, but I think it's important to merge this early to get some exposure of this change to the users of ROOT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reduce the patches between Wim's cppyy and ROOT's while also reducing complexity (if @wlav is fine with it 🙂 ).