Skip to content

Conversation

@hahnjo
Copy link
Member

@hahnjo hahnjo commented May 8, 2025

When there is a problem during upload, the exception is correctly caught but then during handling, another exception occurs:

File "/__w/root/root/.github/workflows/root-ci-config/build_utils.py", line 261, in upload_file
  build_utils.print_warning(f"""Attempt {attempt} to upload {src_file} to {dest_object} failed. Retrying in {sleep_time} seconds...""")
NameError: name 'build_utils' is not defined

Note: I didn't test if this fully fixes the try logic...

When there is a problem during upload, the exception is correctly
caught but then during handling, another exception occurs:

File "/__w/root/root/.github/workflows/root-ci-config/build_utils.py", line 261, in upload_file
  build_utils.print_warning(f"""Attempt {attempt} to upload {src_file} to {dest_object} failed. Retrying in {sleep_time} seconds...""")
NameError: name 'build_utils' is not defined
@hahnjo hahnjo self-assigned this May 8, 2025
@hahnjo hahnjo requested a review from dpiparo as a code owner May 8, 2025 06:33
@hahnjo hahnjo added the in:CI label May 8, 2025
@github-actions
Copy link

github-actions bot commented May 8, 2025

Test Results

    19 files      19 suites   3d 21h 0m 34s ⏱️
 2 739 tests  2 738 ✅ 0 💤 1 ❌
50 569 runs  50 568 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit a4111cf.

@pcanal
Copy link
Member

pcanal commented May 8, 2025

This change has been tested as part of #18469

@pcanal pcanal merged commit 5cabcf6 into root-project:master May 8, 2025
20 of 23 checks passed
@hahnjo hahnjo deleted the ci-retry-error branch May 8, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants