-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[framework] base64 support url decode #3114
[framework] base64 support url decode #3114
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Please put the unit test in the framework code. |
… into feature/my-new-feature
Add base64_tests.move Please review @jolestar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- frameworks/moveos-stdlib/tests/base64_tests.move: Language not supported
Comments suppressed due to low confidence (1)
frameworks/moveos-stdlib/src/natives/moveos_stdlib/base64.rs:64
- The variable 'bytes_ref' is defined but not used directly. It is redundant and should be removed.
let bytes_ref = encoded_input.as_bytes_ref();
Summary
I added a logic check to handle the decoding of both STANDARD and URL_SAFE base64 encoding formats. Please check if there are any issues.
Here is the test code for base64 decode:
result
Please review if there are any issues.