Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] base64 support url decode #2860

Closed
jolestar opened this issue Nov 6, 2024 · 0 comments · Fixed by #3114
Closed

[framework] base64 support url decode #2860

jolestar opened this issue Nov 6, 2024 · 0 comments · Fixed by #3114
Labels
area:stdlib Move stdlib or framework issues help wanted Extra attention is needed proposal New external API or other notable changes skill::move Need the Move language skill to complete the issue skill::rust Need the rust language skill to complete the issue
Milestone
Rooch v0.9

Comments

@jolestar
Copy link
Contributor

jolestar commented Nov 6, 2024

Proposal Details

The base64::decode function only support standard base64 string, not support url safe string.

https://github.com/rooch-network/rooch/blob/3e7c63cf322c3dfd2e6e1419393897eb13cc4294/frameworks/moveos-stdlib/src/natives/moveos_stdlib/base64.rs

Provide new function to support url safe string decode.
@jolestar jolestar added help wanted Extra attention is needed skill::move Need the Move language skill to complete the issue skill::rust Need the rust language skill to complete the issue area:stdlib Move stdlib or framework issues proposal New external API or other notable changes labels Nov 6, 2024
@jolestar jolestar added this to the Rooch v0.9 milestone Nov 6, 2024
@baicaiyihao baicaiyihao mentioned this issue Dec 27, 2024
Merged
@github-project-automation github-project-automation bot moved this to Done in Rooch Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:stdlib Move stdlib or framework issues help wanted Extra attention is needed proposal New external API or other notable changes skill::move Need the Move language skill to complete the issue skill::rust Need the rust language skill to complete the issue
Projects
Rooch
Status: Done
Milestone
Rooch v0.9
Development

Successfully merging a pull request may close this issue.

[framework] base64 support url decode baicaiyihao/rooch
1 participant
@jolestar