Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Excel2003: set namespace if not exist #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Excel2003: set namespace if not exist #56

wants to merge 1 commit into from

Conversation

Mihoid
Copy link

@Mihoid Mihoid commented Sep 16, 2019

Summary

Hi! This PR will help to open/read hard readable files Excel2003 without namespaces in workbook.

@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 83.52% when pulling 569ba70 on evrone:fix/excel-2003-namespacing into 561e295 on roo-rb:master.

@Mihoid
Copy link
Author

Mihoid commented Sep 17, 2019

I will check what's wrong with coverage to fix it.

@Mihoid
Copy link
Author

Mihoid commented Oct 21, 2019

@chopraanmol1 Hi!🤝 Now PR looks good and test coverage fixed. 🙌🏼

@Mihoid
Copy link
Author

Mihoid commented Jan 9, 2020

@amatsuda @Empact @scottwillson Hi! 🙌🏼 Could you check this PR, please.

Thank you in advance!

@Empact
Copy link
Contributor

Empact commented Jan 10, 2020

Thanks for the fix - could you add a line to the test checking the namespace is as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mihoid @coveralls @Empact