Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and effort on p10k!
I use zsh and p10k based on GitBash in Windows, and I find that Battery Prompt is invalid for Windows.
It seems that there does not have a
case
for Windows to call_p9k_prompt_battery_set_args()
. So, I add one for Windows, which useswmic
command to get battery info in Windows. Beside, I add a logic of checking the availability ofwmic
in current Windows system in_p9k_prompt_battery_init()
.After modification, this feature can work well on Windows.
I realize the Battery Prompt may not be seen as necessary on Windows, but I would like to propose that improving it could make a positive impact on the feature's completeness.
Hope you can consider merging.