This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Update fuzzers for 1.70 and integrate with CI #4570
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
jasikpark
reviewed
Jun 28, 2023
| @@ -97,6 +97,10 @@ jobs: | |||
| bins: cargo-fuzz | |||
| - name: Run init-fuzzer | |||
| run: bash fuzz/init-fuzzer.sh | |||
| - name: Run JS fuzzer for 5 minutes | |||
There was a problem hiding this comment.
would it be reasonable to put these in a github action matrix to run them in parallel jobs?
There was a problem hiding this comment.
Potentially so, but we would need to transfer the build artifacts from the common init step. OR split the init step. Both are possible.
There was a problem hiding this comment.
ig a similar thing to do would be to not fail the job if the first fuzz test run fails so the second can also run, with https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This extends #4559 by updating API usage to 1.70 and integrates fuzzer runs into the CI. This should only be merged once all the issues currently present in Rome that are discoverable by the fuzzer are found as to avoid false positives in downstream testing.
By integrating fuzzing into the CI, we can detect regressions immediately -- even if we don't have a unit test for that exact case.
Test Plan
This adds additional tests.
Changelog
Documentation