Fix: Dispose CancellationTokenSource Properly Within CancellationDisposable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lationDisposable is not being disposed neuecc#535
denis-kondratev
changed the title
denis-kondratev
commented
Oct 19, 2023
| if (!IsDisposed) | ||
| { | ||
| _cts.Cancel(); | ||
| } |
There was a problem hiding this comment.
The Dispose() method is designed to be idempotent, allowing for multiple invocations. If a CancellationTokenSource object is created inside CancellationDisposable and gets disposed during the initial call to Dispose(), subsequent attempts to cancel it will result in an exception.
|
Upps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where the
CancellationTokenSourcecreated withinCancellationDisposableis not properly disposed of. For more details, see Issue #535.Clarification on the following code block:
The
Dispose()method is designed to be idempotent, allowing for multiple invocations. If aCancellationTokenSourceobject is created insideCancellationDisposableand gets disposed during the initial call toDispose(), subsequent attempts to cancel it will result in an exception.