fix(commonjs): keep this context for callbacks.

[patricklx]

Rollup Plugin Name: commonjs

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

it's not possible to use the commonjs plugin in vitejs, as some callback functions are not called with the original context.
edit: As I understand now, rollup already binds the context. but vitejs doesn't.

[lukastaegert]

Fair enough, but Rollup already this-binds all context functions. This is by design, but admittedly, this is not well-communicated.

[patricklx]

ah, okay. this issue appeared while using commonjs plugin with vitejs.

[lukastaegert]

Interesting. So I assume this happened in dev mode? Then this would mean that Vite does not this.bind. Maybe an issue to raise with Vite. But this would also make it harder to write a test as you would need to test with a fake plugin context.

[lukastaegert]

Also, Andrew will not like that you skipped the PR template where you should have added all this information.

[tada5hi]

I think so too ^^ 😅

[patricklx]

I added it now

[shellscape]

Looks like you need an upstream update:

git remote add upstream [email protected]:rollup/plugins.git
git fetch upstream
git merge upstream/master
git push

That should get you set so that actions run without errors.

We'll also need a new test that tests this explicit change before we can merge. It's the only way we'll be able to protect against a regression.

@lukastaegert what do you think about this change on the whole, given the info in the other comment thread?

[lukastaegert]

@shellscape I think it is ok.
It would be nice to have some kind of test, but this is really difficult as you would basically need to write a mock Rollup context, which in itself would be hard to maintain and likely not worth the effort, so we can go through with this once CI passes.

[patricklx]

I think now this should be resolved in vitejs to also bind the functions just like rollup.

[patricklx]

I also opened a PR on vitejs.
But according to this comment vitejs/vite#14569 (review)
the functions are not bound in rollup.
I also did a code search and could not find any .bind for load function.
@lukastaegert

[patricklx]

By the way, addWatchFile is not bound and access this.
https://github.com/rollup/rollup/blob/fac5f1c1c12dc0409ff090664e305586747dc2f7/src/utils/PluginContext.ts#L61

[lukastaegert]

Yes, that was indeed overlooked

[shellscape]

@patricklx what's the state of this PR at the moment?

[patricklx]

it should be ready. I also making a PR to vite as well

[shellscape]

@patricklx circling back to this one. looks like linting need to be run locally, prettier isn't happy in CI.

[patricklx]

@shellscape fixed prettier

[shellscape]

@patricklx thanks for fixing the last issue. it looks like your changes are good to go, but we require tests for fixes and features to protect against regressions. would you be able to add a test for these changes?