Using Rolldown with Vite v6

[sapphi-red]

Description

Applied changes from #24 and #27 to the main branch after the environment API PR is merged.
Also fixed errors on Windows and cleaned up some unneeded changes.

#24 implemented build-time dep optimization partially, but I didn't include that change in this PR.

e2e test status

Playground Name	Dev	Build	Reasons
alias	✅	✅
assets	✅	✅	NOTE: watch mode tests are skipped
assets-sanitize	✅	✅
backend-integration	✅	✅	NOTE: changed the test case that was relying on rollup specific chunking behavior (rolldown/rolldown#1842 (comment))
build-old	✅	✅	-
cli	✅	✅	-
cli-module	✅	✅	-
config	✅	✅	-
csp	✅	✅	-
css	✅	✅	-
css-codesplit	✅	✅	NOTE: uses advancedChunks instead of manualChunks
css-codesplit-cjs	✅	✅	-
css-dynamic-import	✅	✅
css-lightningcss	✅	✅	-
css-lightningcss-proxy	✅	✅	-
css-lightningcss-root	✅	✅	-
css-no-codesplit	✅	✅	-
css-sourcemap	✅	✅	-
data-uri	✅	✅	-
define	✅	✅	-
dynamic-import	✅	✅
dynamic-import-inline	-	✅
env	✅	✅	-
env-nested	✅	✅	-
environment-react-ssr	✅	⚠️	NOTE: passing but workarounds are applied to get around rolldown/rolldown#2685
extensions	✅	✅	-
external	✅	❌	rolldown/rolldown#2041
fs-serve	✅	✅	-
glob-import	✅	⚠️	NOTE: passing but workarounds are applied to get around rolldown/rolldown#2394
hmr	✅	✅	-
hmr-root	✅	-	-
hmr-ssr	✅	✅	-
html	✅	⚠️	NOTE: passing but rolldown/rolldown#2781 should be fixed to make it work correctly in some cases
import-assertion	✅	✅	-
js-sourcemap	✅	✅	NOTE: uses advancedChunks instead of manualChunks
json	✅	✅	-
legacy	❌	❌	🟡pending support system format
lib	✅	✅	-
minify	-	✅	-
module-graph	✅	-	-
multiple-entrypoints	✅	✅	-
nested-deps	✅	✅	-
object-hooks	✅	❌	object hook sequential
optimize-deps	✅	❌	rolldown/rolldown#2031
optimize-deps-no-discovery	✅	✅	-
optimize-missing-deps	✅	✅	-
preload	✅	✅	-
preserve-symlinks	✅	✅	-
proxy-bypass	✅	✅	-
proxy-hmr	✅	✅	-
resolve	✅	✅	NOTE: skipped some browser field related tests as those cases were only supported by esbuild and Vite, also skipped some test that does fallback based on the file content which is Vite only and I believe it should not be done
resolve-config	-	✅
ssr	✅	✅	-
ssr-alias	✅	✅	-
ssr-conditions	✅	✅	-
ssr-deps	✅	✅	-
ssr-html	✅	✅	-
ssr-noexternal	✅	-	-
ssr-pug	✅	✅	-
ssr-resolve	-	✅	-
ssr-webworker	✅	✅
tailwind	✅	✅	-
tailwind-sourcemap	✅	✅	-
transform-plugin	✅	✅
tsconfig-json	✅	❌	experimental decorators and useDefineForClassFields: false is not supported by oxc (rolldown/rolldown#2296, oxc-project/oxc#6735)
tsconfig-json-load-error	✅	✅	-
wasm	✅	✅	-
worker	✅	✅	-

⚠️ skipped one unit test due to rolldown/rolldown#2828

needs rolldown/rolldown#2833 to update rolldown to latest

missing feature list that was supported by esbuild / rollup

• names/originalNames support [Bug]: names / originalFileNames support rolldown#2496: removed related code from Vite
• watch mode ([Feature Request]: watch mode rolldown#2028)
  • options.watch
  • watcher.on('event', listener)
  • related hooks: shouldTransformCachedModule, watchChange, closeWatcher
  • this.addWatchFile
• meta on module info: this can be workarounded as it's not part of the public API
• system format
• generating multiple formats in one build: output is currently an object instead of an array
• options.attributes for resolveId hook
• SourceMap type does not support toString and toUrl: not necessary but better for easier migration
• resolveImportMeta hook: can use transform hook for Vite's usecase
• options.preserveEntrySignatures: not necessary but nice for smaller bundles
• cancelling the running build / scan (esbuild docs): since rolldown is fast, it's not important to have this feature, but would be nice to reduce energy consumption
• options around the optimizer: 9d7d4f0

oxc missing feature list that was supported by esbuild

• experimental decorators support ([Bug]: passes TypeScript experimental decorators as-is rolldown#2296)
• useDefineForClassFields (transformer: typescript --useDefineForClassFields oxc-project/oxc#6735)
• keepNames: we might not need this for oxc?

improvements needed later on Vite side

• cache this: bb8b41f#diff-00039b783552b3f2a608918986716e01b1a71996da1a8ad5493a102a1e969d7bR659-R662

native plugin incompatibilities

• alias: does not support customResolver option
• import-glob
  • does not support alias
  • does not support subpath imports: https://github.com/rolldown/rolldown/blob/4caa0a93f9ed42bcf9e152c6a4949bacd879b932/crates/rolldown_plugin_import_glob/src/lib.rs#L457
• manifest: cannot use data on Vite side (e.g. css/assets) and needs to be environment-specific
  • I cannot make a simple reproduction for this one. If you only enable the native manifest plugin and run build in playground/backend-integration, you can see the manifest not containing css and assets field in index.html.
  • needs to use different options for each environment
• json
  • stringify: 'auto' support: feat(json)!: add json.stringify: 'auto' and make that the default vitejs/vite#18303
• resolver
  • use it for createIdResolver as well

TODO list for me

• think about what to do with commonjsOptions
• vitepress assigns to bundle: https://github.com/vuejs/vitepress/blob/68150a6f3349c1741ed5683e3010d9ecea02f3a8/src/node/plugin.ts#L353-L362
• organize what is left to make it possible to release rolldown-vite / rolldown-vite (with native plugins)
  • rolldown-vite
    • first make a resolver plugin using oxc-resolver and add an option to use that in non-rolldown vite?
  • rolldown-vite (with native plugins)
    • how to make native plugins work in dev? (e.g. use non-native for dev)
• convert esbuild.tsconfigRaw/esbuild.tsconfig to oxc

[IWANABETHATGUY]

FYI,

alias: does not support customResolver option

this is by design, if use customResolver in native plugin, there is no performance difference between js Alias and rust alias, since you always need to perform a tsfn, and make plugin execute single threaded

[IWANABETHATGUY]

for all native plugin incompatibilities section, could you give a more specific testcase?

[sapphi-red]

@IWANABETHATGUY I've made reproductions for the cases other than resolve plugin related ones. (I'm going to make for the resolve related ones now.)

[sapphi-red]

I fixed the import-meta glob reproduction; it was using import.meta.dirname but wasn't supported by stackblitz yet.

[IWANABETHATGUY]

I fixed the import-meta glob reproduction; it was using import.meta.dirname but wasn't supported by stackblitz yet.

Can you file these issues on rolldown?

[sapphi-red]

Made the reproductions for resolve related ones.

Can you file these issues on rolldown?

Did you mean to quote #43 (comment) instead of #43 (comment), right?

[IWANABETHATGUY]

Made the reproductions for resolve related ones.

Can you file these issues on rolldown?

Did you mean to quote #43 (comment) instead of #43 (comment), right?

Sorry, yeah I mean #43 (comment)

[sapphi-red]

Done 👍

I didn't make an issue for "manifest: cannot use data on Vite side (e.g. css/assets) and needs to be environment-specific" and "does not support vitejs#12786 (reproduction, expected to have console.log preserved in the output)" for now as I'm not sure what the next step is and the issue will be opaque / unactionable.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/rolldown/vite@43

commit: 437ff57

[IWANABETHATGUY]

Maybe we should squash it instead of merge