Convert build to webpack #200

TwitchBronBron · 2019-09-21T00:43:57Z

As per the recommendation of the vscode extension team, (that naggy message after every vsix build), I converted the build process to use webpack.

codecov · 2019-09-21T00:47:46Z

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   39.39%   39.39%           
=======================================
  Files          84       84           
  Lines        2853     2853           
  Branches      531      531           
=======================================
  Hits         1124     1124           
  Misses       1610     1610           
  Partials      119      119

Impacted Files	Coverage Δ
src/BrightScriptCommands.ts	`16.9% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b483a98...6f4883e. Read the comment docs.

TwitchBronBron · 2019-09-21T18:00:40Z

@triwav, @chrisdp, @georgejecook, Could you guys pull down this PR, build it, and make sure everything works well for you? It seemed to work just fine for me...but since completely changing the build system is a pretty substantial change, i'd feel better with a few other people validating that it works properly before I merge it.

georgejecook · 2019-09-22T14:19:40Z

Seems to work for package, and I can build and run in vscode

get these unit test failures.

2 failing

  1) Debugger
       updateManifestBsConsts
         should throw error when there is no bs_const line:
     TypeError: assert.rejects is not a function
      at Object.<anonymous> (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:157:26)
      at Generator.next (<anonymous>)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:7:71
      at new Promise (<anonymous>)
      at __awaiter (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:3:12)
      at Context.it (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:156:76)
      at callFn (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:372:21)
      at Test.Runnable.run (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:364:7)
      at Runner.runTest (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:455:10)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:573:12
      at next (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:369:14)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:379:7
      at next (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:303:14)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:342:7
      at done (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:319:5)
      at callFn (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:395:7)
      at Hook.Runnable.run (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:364:7)
      at next (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:317:10)
      at Immediate.<anonymous> (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:347:5)
      at runCallback (timers.js:763:18)
      at tryOnImmediate (timers.js:734:5)
      at processImmediate (timers.js:716:5)

  2) Debugger
       updateManifestBsConsts
         should throw error if there is consts in the bsConsts that are not in the manifest:
     TypeError: assert.rejects is not a function
      at Object.<anonymous> (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:164:26)
      at Generator.next (<anonymous>)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:7:71
      at new Promise (<anonymous>)
      at __awaiter (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:3:12)
      at Context.it (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/src/BrightScriptDebugSession.spec.ts:162:109)
      at callFn (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:372:21)
      at Test.Runnable.run (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:364:7)
      at Runner.runTest (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:455:10)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:573:12
      at next (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:369:14)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:379:7
      at next (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:303:14)
      at /Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:342:7
      at done (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:319:5)
      at callFn (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:395:7)
      at Hook.Runnable.run (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runnable.js:364:7)
      at next (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:317:10)
      at Immediate.<anonymous> (/Users/georgecook/Documents/h7ci/hope/vscode/vscode-brightscript-language/node_modules/mocha/lib/runner.js:347:5)
      at runCallback (timers.js:763:18)
      at tryOnImmediate (timers.js:734:5)
      at processImmediate (timers.js:716:5)



npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] test: `ts-mocha "src/**/*.spec.ts" --full-trace`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/georgecook/.npm/_logs/2019-09-22T14_16_39_221Z-debug.log
Mac-mini-2:vscode-brightscript-language georgecook$```

chrisdp · 2020-04-03T06:10:52Z

What’s the status of this Pr? Is this moot due to our move to git workflows with v2?

TwitchBronBron · 2020-04-03T11:11:07Z

It's still something i'd like to do. It'll drastically reduce the the extension package size. However, I want to do more testing on it first to see if it's any slower during development. In my experience, the webpack projects I work on for my day job are usually a good bit slower, so before we make the switch I want to make sure it won't have a negative impact on our development cycle.

It's not overly critical, so I'll get to it eventually. :D

TwitchBronBron · 2021-11-05T18:05:26Z

Closing in favor of #335

Converted build to webpack

7ef638b

TwitchBronBron changed the title ~~Converted build to webpack~~ Convert build to webpack Sep 21, 2019

TwitchBronBron requested a review from chrisdp September 21, 2019 00:44

TwitchBronBron requested a review from triwav September 21, 2019 17:59

Merge branch 'master' into webpack-build

d1408e9

TwitchBronBron added 2 commits September 24, 2019 07:38

Merge branch 'master' into webpack-build

2bd2bd2

Merge branch 'master' into webpack-build

a2a1da5

chrisdp approved these changes Oct 2, 2019

View reviewed changes

TwitchBronBron added 2 commits October 2, 2019 15:04

Merge branch 'master' into webpack-build

1fb207d

Merge branch 'master' into webpack-build

6f4883e

PabloSchmidtRokuDev approved these changes May 28, 2021

View reviewed changes

TwitchBronBron mentioned this pull request Nov 5, 2021

Bundle extension using esbuild #335

Open

4 tasks

TwitchBronBron closed this Nov 5, 2021

TwitchBronBron deleted the webpack-build branch November 5, 2021 18:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert build to webpack #200

Convert build to webpack #200

TwitchBronBron commented Sep 21, 2019

codecov bot commented Sep 21, 2019 •

edited

Loading

TwitchBronBron commented Sep 21, 2019

georgejecook commented Sep 22, 2019

chrisdp commented Apr 3, 2020

TwitchBronBron commented Apr 3, 2020

TwitchBronBron commented Nov 5, 2021

Convert build to webpack #200

Convert build to webpack #200

Conversation

TwitchBronBron commented Sep 21, 2019

codecov bot commented Sep 21, 2019 • edited Loading

Codecov Report

TwitchBronBron commented Sep 21, 2019

georgejecook commented Sep 22, 2019

chrisdp commented Apr 3, 2020

TwitchBronBron commented Apr 3, 2020

TwitchBronBron commented Nov 5, 2021

codecov bot commented Sep 21, 2019 •

edited

Loading