Upgrading to Brighterscript v1 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwpearce
commented
Aug 1, 2024
| @@ -115,3 +129,12 @@ export function getScopeForSuite(testSuite: TestSuite) { | |||
| return testSuite.file.program.getFirstScopeForFile(testSuite.file); | |||
| } | |||
| } | |||
|
|
|||
| export function getFileLookups(file: BrsFile): CachedLookups { | |||
There was a problem hiding this comment.
New function to replace file.parser.references
markwpearce
commented
Aug 1, 2024
| (bsFile as BrsFile).parser.statements.push(); | ||
| bsFile.needsTranspiled = true; | ||
| } | ||
| //let bsFile = program.getFile(suite.bsPkgPath); |
There was a problem hiding this comment.
I don't think this is needed anymore in v1
markwpearce
commented
Aug 1, 2024
| @@ -14,7 +14,10 @@ function addDiagnostic( | |||
| severity: DiagnosticSeverity = DiagnosticSeverity.Error | |||
| ) { | |||
| endLine = endLine === -1 ? startLine : endLine; | |||
| file.addDiagnostics([createDiagnostic(file, code, message, startLine, startCol, endLine, endCol, severity)]); | |||
| file.program.diagnostics.register( | |||
There was a problem hiding this comment.
Using new diagnostics manager
markwpearce
commented
Aug 1, 2024
markwpearce
commented
Aug 1, 2024
| @@ -15,18 +15,18 @@ namespace rooibos | |||
| protected hasIgnoredTests = false | |||
| protected isSolo = false | |||
| protected isIgnored = false | |||
| protected noCatch = false | |||
| public noCatch = false | |||
There was a problem hiding this comment.
Many changes in the .BS files to support proper typing and to fix validation errors
markwpearce
commented
Aug 1, 2024
tests/bsconfig.json
Outdated
| @@ -3,7 +3,8 @@ | |||
| "files": [ | |||
| "manifest", | |||
| "source/**/*.*", | |||
| "components/**/*.*" | |||
| "components/**/*.*", | |||
| { "src": "../../framework/src/source/**/*", "dest": "source/rooibos" } | |||
There was a problem hiding this comment.
Be able to import the framework in the tests
markwpearce
commented
Aug 1, 2024
…ipt for running rooibos tests from command line
markwpearce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
Also: