Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rooibos currently uses an if-switch statement block to determine which test suites should be run. This results in lots of duplicate code, and usually having a Roku compiler error due to bytecode chunk constant limitations when too many test suites are present.
This happens with the latest Rooibos version when I have >=300 test suites. I usually have to batch them so the devices in my CI don't freak out.
Here's an example of what
source/rooibos/RuntimeConfig.brs
looks like at the moment:This PR changes that to use an AA instead, which uses up less code:
Some notes:
if
checks in large collections.m.testSuites.keys()
, this change has the unintended side-effect of ensuring A-Z sorting of all test suites. I've made it less unintended by having the plugin sort thetestSuitesToRun
array.