Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where scope validations where incomplete for node tests #280

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

chrisdp
Copy link
Collaborator

@chrisdp chrisdp commented Mar 26, 2024

There was a bug where scope validations would not be run on node tests because the generated xml test components where being added to the program too late.

@chrisdp chrisdp added the bug Something isn't working label Mar 26, 2024
@chrisdp chrisdp requested a review from georgejecook March 26, 2024 14:47
@chrisdp
Copy link
Collaborator Author

chrisdp commented Jun 25, 2024

@georgejecook fixed conflicts

@TwitchBronBron TwitchBronBron merged commit d81fc64 into master Jul 2, 2024
5 checks passed
@TwitchBronBron TwitchBronBron deleted the bugfix/missing-diagnostics-in-node-tests branch July 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants