Skip to content

Commit

Permalink
Fix/fix incorrect empty message (#173)
Browse files Browse the repository at this point in the history
* bump

* fix(asserts): fixes incorrect empty message
  • Loading branch information
georgejecook authored May 24, 2022
1 parent 4f2f018 commit fd728ce
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
11 changes: 10 additions & 1 deletion bsc-plugin/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,19 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [5.0.0](https://github.com/georgejecook/rooibos/compare/4.8.2...5.0.0)
#### [5.0.1](https://github.com/georgejecook/rooibos/compare/5.0.0...5.0.1)

- fix(core): fixes incorrect class name equality checks [`#172`](https://github.com/georgejecook/rooibos/pull/172)

### [5.0.0](https://github.com/georgejecook/rooibos/compare/4.8.2...5.0.0)

> 23 May 2022
- fix(asserts): improves like,and imrpoves output for types, across the board [`#171`](https://github.com/georgejecook/rooibos/pull/171)
- Use AstEditor for all transpile modifications [`#159`](https://github.com/georgejecook/rooibos/pull/159)
- bump [`2384504`](https://github.com/georgejecook/rooibos/commit/23845045f2ca7ee75f7968103ddeb8782dd43ca5)
- bump [`0707ec8`](https://github.com/georgejecook/rooibos/commit/0707ec8d79cba8ffc7f6ab1cc62e527283f3a21a)
- bump [`6367ded`](https://github.com/georgejecook/rooibos/commit/6367ded9bdd4e1d4d3356140b7963972a343f4a3)

#### [4.8.2](https://github.com/georgejecook/rooibos/compare/4.8.1...4.8.2)

Expand Down
2 changes: 1 addition & 1 deletion bsc-plugin/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rooibos-roku",
"version": "5.0.0",
"version": "5.0.1",
"description": "simple, flexible, fun brightscript test framework for roku scenegraph apps - roku brighterscript plugin",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion framework/src/source/BaseTestSuite.bs
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ namespace rooibos
end if
else if Rooibos.Common.isString(item)
if Rooibos.Common.asString(item) <> ""
msg = "Input value is not empty."
msg = "String is not empty, contains: " + Rooibos.Common.asString(item, true)
m.currentResult.fail(msg, m.currentAssertLineNumber)
return false
end if
Expand Down
4 changes: 2 additions & 2 deletions framework/src/source/CommonUtils.bs
Original file line number Diff line number Diff line change
Expand Up @@ -305,13 +305,13 @@ namespace rooibos.Common
' */
function asString(input, includeType = false) as string
if Rooibos.Common.isValid(input) = false
return "INVALID"
else if Rooibos.Common.isString(input)
if includeType
return """" + input + """"
else
return input
end if
else if Rooibos.Common.isString(input)
return """" + input + """"
else if Rooibos.Common.isInteger(input) or Rooibos.Common.isLongInteger(input) or Rooibos.Common.isBoolean(input)
if includeType
return input.ToStr() + " (" + Rooibos.Common.getSafeType(input) + ")"
Expand Down

0 comments on commit fd728ce

Please sign in to comment.