Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exceptions on missing options #156

Merged
merged 83 commits into from
Mar 26, 2024
Merged

Throw exceptions on missing options #156

merged 83 commits into from
Mar 26, 2024

Conversation

MilapNaik
Copy link
Collaborator

Fixes #149

MilapNaik and others added 30 commits January 2, 2024 13:39
@MilapNaik
Make change to assume dest folder. Delete 2 old tests that looked for…
c6d2536 
… old behavior, add 2 more tests that look for new behavior
@MilapNaik
Sort files
2ba8eca
@MilapNaik @TwitchBronBron
Update src/RokuDeploy.ts
cc92e04 
Co-authored-by: Bronley Plumb <[email protected]>
@MilapNaik
Removed redundant entry.dest is null situation
9bbd579
@MilapNaik
Added a few commands, not all are working correctly
460cbf6
@MilapNaik
Merge branch 'v4' into add-cli-commands
de269ed 
# Conflicts:
#	src/RokuDeploy.ts
@MilapNaik
Merge branch 'fix-src-dest-handling' into add-cli-commands
7b9ee29
@MilapNaik
Move commands to their own file
6db962a
@MilapNaik
More command files
20eb21f
@MilapNaik
Change commands to help with tests
4e4b66a
@MilapNaik
Add testing suite for all cli (2 tests are not working)
2b809e6
@MilapNaik
Updated cli file after adding in commands and tests
13f2ca4
@MilapNaik
Fixed a few test cases
2d13441
@MilapNaik
Change name and input of table helper
09a275f
@TwitchBronBron
Totally broken code, but have the right names
e34ac97
@MilapNaik
Changed name of toTable
52b1bc0
@MilapNaik
Make test for objectToTable
f3a0c56
@MilapNaik
add yargs to pacjage.json
b5f41ca
@MilapNaik
add package-lock.json
4b95943
@MilapNaik
add new line at eof
b6c6223
@MilapNaik
Add test for coverage, also remove an unncessary '?'
f15f295
@MilapNaik
Merge branch 'add-cli-commands' into rename
08a587e 
# Conflicts:
#	src/util.ts
@TwitchBronBron
tweaks
6941e86
@TwitchBronBron
tweaks
ea49342
@TwitchBronBron
get from json stuff
616ff23
@MilapNaik
Merge branch 'v4' into rename
e2f3f80 
# Conflicts:
#	src/RokuDeploy.ts
#	src/cli.ts
#	src/commands/DeleteInstalledChannelCommand.ts
#	src/commands/GetDeviceInfoCommand.ts
#	src/commands/PrepublishCommand.ts
#	src/commands/PublishCommand.ts
#	src/commands/SignExistingPackageCommand.ts
#	src/commands/TakeScreenshotCommand.ts
#	src/commands/ZipPackageCommand.ts
#	src/index.ts
#	src/util.spec.ts
#	src/util.ts
@MilapNaik
Merge branch 'v4' into rename
190a2f1 
# Conflicts:
#	src/index.ts
@MilapNaik
Correct imports
cacf433
@MilapNaik
Last of the fsExtra changes
cbd6417
@MilapNaik
Create a load from json util, clean up cli.ts file with fleshing out …
ebab568 
…comments, delete unnecessary command/tests/options, partially fix exec command
MilapNaik and others added 19 commits March 18, 2024 15:43
@MilapNaik
Add function description
200e537
@MilapNaik
Inline exec command options
a669ee3
@MilapNaik
Remove retainsStagingDir, zipCallBackInfo, incrementBuildNumber, and …
906856e 
…add back tests for createPackage
@MilapNaik
Delete convertToSquashfs, move deployAndSignPackage tests to cli, mov…
d065bd5 
…e retrieveSignedPackage tests to under createSignedPackage
@MilapNaik
Change prepublishToStaging to stage
0f17569
@MilapNaik
Change the way close channel works
94fa701
@MilapNaik @TwitchBronBron
Update src/RokuDeploy.ts
f64ab5d 
Co-authored-by: Bronley Plumb <[email protected]>
@MilapNaik
Add outFile to Zip, delete zipPackage
4ffc8f7
@MilapNaik
StagingDir is defaulted anyway so this error will never occur
94a4d43
@MilapNaik
Delete MissingRequiredOptionError
782ec22
@MilapNaik
Add checkRequiredOptions function to test for required options
895c250
@MilapNaik
Add checking for required options in sendKeyEvent function, start tes…
469a62a 
…ting
@MilapNaik
Add check for if options are part of the defined interface that they …
76b1f7d 
…are being called with
@MilapNaik
Add check for various required options and add tests for each one
9e44992
@MilapNaik
Merge branch 'v4' into throw-exceptions-on-missing-params
3734501 
# Conflicts:
#	src/RokuDeploy.spec.ts
#	src/RokuDeploy.ts
@MilapNaik
take out it.only in tests
db3d782
@MilapNaik
Delete old MissingRequiredOptionError tests
e11ae26
@MilapNaik
fix tests
b298acb
@MilapNaik
Fix lint error
d9397d5
TwitchBronBron
TwitchBronBron reviewed Mar 26, 2024
View reviewed changes
src/RokuDeploy.ts Outdated Show resolved Hide resolved
TwitchBronBron
TwitchBronBron requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion.

@TwitchBronBron TwitchBronBron merged commit ab389e0 into v4 Mar 26, 2024
6 checks passed
@TwitchBronBron TwitchBronBron deleted the throw-exceptions-on-missing-params branch March 26, 2024 19:11
@TwitchBronBron TwitchBronBron added this to the v4.0.0 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MilapNaik @TwitchBronBron