Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
approved these changes
Feb 26, 2024
TwitchBronBron
added a commit
that referenced
this pull request
Apr 30, 2024
* Update wrong host password error message (#134) * Update wrong host password error message * Fix unit test to look for the updated message * Get 100% code coverage * Update changelog for v3.11.2 * 3.11.2 * Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error (#145) * Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error * Add a clarifying comment and a new test case * Add two more test cases to get to 100% code coverage * Another test in pursuit of 100% * Remove optional chaining on catch. The error is always going to be set * Update changelog for v3.11.3 * 3.11.3 * Support overriding various package upload form data (#136) * Support overriding various package upload form data * adds support for squashfs deployments --------- Co-authored-by: George Cook <[email protected]> * Update changelog for v3.12.0 * 3.12.0 * Merge branch 'master' into v4 # Conflicts: # CHANGELOG.md # package-lock.json # package.json # src/RokuDeploy.spec.ts # src/RokuDeploy.ts # src/RokuDeployOptions.ts - deleteDevChannel call was added which changed order of sideload post requests - output file in makezip was changed to writefile * readme info for retain staging dir deleted * readded example * fix package lock * Fix Ci --------- Co-authored-by: Christian-Holbrook <[email protected]> Co-authored-by: Bronley Plumb <[email protected]> Co-authored-by: George Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally see the convertToSquashfs request fail. It seems determined by the size of the zip and the length of the file name. The Roku responds with half of the response body and roku-deploy cannot handle the bad data.
The squashfs conversion looks like it successfully created, the error is in the response.
The work around is to make a second request to squashfs when we see the 'HPE_INVALID_CONSTANT' error. If that response includes 'fileType': 'squashfs' then we return the result saying it succeeded.