Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created focused/specific interfaces for each function #125

Closed
TwitchBronBron opened this issue Nov 6, 2023 · 1 comment
Closed

Created focused/specific interfaces for each function #125

TwitchBronBron opened this issue Nov 6, 2023 · 1 comment
Milestone

Comments

@TwitchBronBron
Copy link
Member

TwitchBronBron commented Nov 6, 2023

Many of the roku-deploy public functions take the RokuDeployOptions interface. That's very confusing because it's huge and has many options that many of the functions don't actually need. We should do the following:

  • create a unique interface for each of the public functions that only declare the properties they actually use/require.
  • export the interfaces and give them helpful names so external developers can use them in their code.
@MilapNaik
Copy link
Collaborator

in #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants