Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the function parameters so they have only the options they need #123

Closed
TwitchBronBron opened this issue Nov 3, 2023 · 2 comments
Milestone

Comments

@TwitchBronBron
Copy link
Member

We currently allow the global roku-deploy options to just be passed around everywhere, which makes all the functions much more confusing because most of the time they don't need most of those options.

We need to create separate objects/interfaces for each function call, so it's clear how to use each one.

@MilapNaik
Copy link
Collaborator

In #126

@TwitchBronBron
Copy link
Member Author

Closing in favor of #125

@TwitchBronBron TwitchBronBron removed the v4 label Feb 1, 2024
@TwitchBronBron TwitchBronBron added this to the v4.0.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants