Change deleteInstalledChannel to deleteDevChannel, other small changes

rokucommunity · Feb 29, 2024 · 2858dd6 · 2858dd6
1 parent f5ba839
commit 2858dd6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/src/RokuDeploy.ts b/src/RokuDeploy.ts
@@ -556,7 +556,7 @@ export class RokuDeploy {
      * Deletes any installed dev channel on the target Roku device
      * @param options
      */
-    public async deleteDevChannel(options?: DeleteInstalledChannelOptions) {
+    public async deleteDevChannel(options?: DeleteDevChannelOptions) {
         options = this.getOptions(options) as any;
 
         let deleteOptions = this.generateBaseRequestOptions('plugin_install', options as any);
@@ -647,7 +647,7 @@ export class RokuDeploy {
             retainDeploymentArchive: true,
             incrementBuildNumber: false,
             failOnCompileError: true,
-            deleteInstalledChannel: true,
+            deleteDevChannel: true,
             packagePort: 80,
             remotePort: 8060,
             timeout: 150000,
@@ -1013,7 +1013,7 @@ export interface CreateSignedPackageOptions {
     devId?: string;
 }
 
-export interface DeleteInstalledChannelOptions {
+export interface DeleteDevChannelOptions {
     host: string;
     password: string;
 }
@@ -1029,7 +1029,7 @@ export interface DeployOptions {
     files?: FileEntry[];
     rootDir?: string;
     stagingDir?: string;
-    deleteInstalledChannel?: boolean;
+    deleteDevChannel?: boolean;
     outFile?: string;
     outDir?: string;
 }

diff --git a/src/cli.spec.ts b/src/cli.spec.ts
@@ -68,7 +68,7 @@ describe('cli', () => {
     });
 
     it('Publish passes proper options', async () => {
-        const stub = sinon.stub(rokuDeploy, 'publish').callsFake(async () => {
+        const stub = sinon.stub(rokuDeploy, 'sideload').callsFake(async () => {
             return Promise.resolve({
                 message: 'Publish successful',
                 results: {}

diff --git a/src/device.spec.ts b/src/device.spec.ts
@@ -2,7 +2,7 @@ import * as assert from 'assert';
 import * as fsExtra from 'fs-extra';
 import type { RokuDeployOptions } from './index';
 import { rokuDeploy } from './index';
-import { cwd, expectPathExists, expectThrowsAsync, outDir, rootDir, tempDir, writeFiles } from './testUtils.spec';
+import { cwd, expectThrowsAsync, outDir, rootDir, tempDir, writeFiles } from './testUtils.spec';
 import * as dedent from 'dedent';
 
 //these tests are run against an actual roku device. These cannot be enabled when run on the CI server
@@ -79,14 +79,4 @@ describe('device', function device() {
             );
         });
     });
-
-    describe('deployAndSignPackage', () => {
-        it('works', async () => {
-            await rokuDeploy.deleteInstalledChannel(options as any);
-            await rokuDeploy.rekeyDevice(options as any);
-            expectPathExists(
-                await rokuDeploy.deployAndSignPackage(options as any)
-            );
-        });
-    });
 });