-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caught uncaught exceptions #198
base: master
Are you sure you want to change the base?
Conversation
…ommunity/roku-debug into caught-uncaught-exceptions
…etween app relaunches
.github/workflows/build.yml
Outdated
@@ -25,7 +25,7 @@ jobs: | |||
- run: npm ci | |||
- run: npm run build | |||
- run: npm run lint | |||
- run: npm run test | |||
- run: npx cross-env NODE_OPTIONS="--max-old-space-size=4096" npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't do this. The problem is most likely that you upgraded something in the package-lock (did you perhaps run npm audit fix
? That does it sometimes).
There's a package in there somewhere that isn't happy with the current node version.
Can you roll back the package-lock, delete node_modules, and run npm install
again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to "manually" revert back to the original package.json and commit the newly generated package-lock.json. This caused some other errors where the dependencies were missing some exported functions.
I ended up just running git checkout master -- package.json package-lock.json
and committed that. That should roll back all the changes on this branch to master for any package*.json changes.
The first run of checks failed because 1 unit tests did not pass on the ubuntu CI. I reran it and all the tests pass.
Have you had trouble with the test show in the attached screenshot?
Work in progress.