Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Protocol Enhancements #107

Merged
merged 80 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
09949dc
Add initial DebugProtocolServer and handshake test
TwitchBronBron Oct 6, 2022
7b99680
Add test plugin to intercept requests.
TwitchBronBron Oct 6, 2022
205070e
Port "not correct magic" test to new flow
TwitchBronBron Oct 6, 2022
1284e15
Fix handshake version handling
TwitchBronBron Oct 7, 2022
f47c84d
Adds all request classes
TwitchBronBron Oct 7, 2022
9cb3d09
Refactored response classes
TwitchBronBron Oct 9, 2022
c56ab79
Add more updates
TwitchBronBron Oct 11, 2022
1b2c9f5
Move readStringNT to protocolUtils.
TwitchBronBron Oct 11, 2022
b479dc7
Migrate more responses to new structure
TwitchBronBron Oct 11, 2022
9d39c00
Many more tweaks. VariablesRequest mostly functional now
TwitchBronBron Oct 11, 2022
29c4bc3
More fixes
TwitchBronBron Oct 12, 2022
8dedad4
Fix VariablesResponse
TwitchBronBron Oct 12, 2022
00c6f97
Fix tsc errors
TwitchBronBron Oct 12, 2022
dff64ee
Fix handshake request/response issues.
TwitchBronBron Oct 12, 2022
fe00be5
PascalCase enums
TwitchBronBron Oct 13, 2022
6580915
Fix forceCaseInsensitive variables command logic
TwitchBronBron Oct 13, 2022
1021314
Fix unit tests and add better logging.
TwitchBronBron Oct 13, 2022
241a9db
Fix npm package issues
TwitchBronBron Jan 11, 2023
b52dcaf
Rename ProtocolUtils to singular.
TwitchBronBron Jan 11, 2023
c25a681
test enable/disable flags
TwitchBronBron Jan 11, 2023
fee7848
Fix broken tests
TwitchBronBron Jan 11, 2023
59d8be6
test tcp server defaults
TwitchBronBron Jan 11, 2023
307cf27
Fix lint issue
TwitchBronBron Jan 11, 2023
59435d9
better HandshakeResponse coverage
TwitchBronBron Jan 11, 2023
1d7a614
Handle all variable types
TwitchBronBron Jan 24, 2023
8f2d10c
Responses 100% coverage
TwitchBronBron Jan 24, 2023
8260f7a
More DebugProtocolClient tests
TwitchBronBron Jan 24, 2023
a78f835
fix server support mulitple requests in single buffer
TwitchBronBron Jan 25, 2023
61c77d8
Support for DebugProtocolReplaySession
TwitchBronBron Feb 1, 2023
70db47d
Add basic ProtocolClient plugin support
TwitchBronBron Feb 1, 2023
8aa40bd
Better logging
TwitchBronBron Feb 1, 2023
df3afb9
Better port handling in ReplaySession
TwitchBronBron Feb 1, 2023
5a4c093
Fix io socket replacing server socket
TwitchBronBron Feb 2, 2023
b8eb58a
Fix several bugs.
TwitchBronBron Feb 8, 2023
c336e32
Process more frequently
TwitchBronBron Feb 8, 2023
70ef80a
Discard unrecognized updates/responses
TwitchBronBron Feb 8, 2023
b2520ee
Clean up sockets after session is complete
TwitchBronBron Feb 8, 2023
f0a9675
Fixed socket issues during testing
TwitchBronBron Feb 14, 2023
2f65862
fix port issues
TwitchBronBron Feb 14, 2023
a230d47
Merge branch 'master' of https://github.com/rokucommunity/roku-debug …
TwitchBronBron Feb 15, 2023
c9587db
try to prevent getting stuck
TwitchBronBron Feb 15, 2023
a7c1a0d
only run the PR build
TwitchBronBron Feb 15, 2023
870ad7b
Try fixing logging issues
TwitchBronBron Feb 15, 2023
adb66b8
skip failing test.
TwitchBronBron Feb 15, 2023
06f5c79
skip another
TwitchBronBron Feb 15, 2023
1b6a714
increase timeout for all tests, reenable disabled
TwitchBronBron Feb 15, 2023
424ee08
Fix node 12 server never close
TwitchBronBron Feb 16, 2023
4780cfb
Better socket teardowns
TwitchBronBron Feb 16, 2023
6547df7
fix broken breakpoint response in ProtocolClient
TwitchBronBron Feb 16, 2023
578253b
Better tests for breakpoint requests
TwitchBronBron Feb 16, 2023
d068755
Fix empty stack trace response
TwitchBronBron Feb 16, 2023
bd52c63
Refactor protocol vars logic (local vars broken)
TwitchBronBron Feb 17, 2023
f74467b
fix tests
TwitchBronBron Feb 17, 2023
fd25572
Fix local vars and add array size
TwitchBronBron Feb 17, 2023
d89fcea
rename "AA" to "AssociativeArray"
TwitchBronBron Feb 21, 2023
4629231
add new util.hasNonNullishProperty func
TwitchBronBron Feb 27, 2023
a3c5d61
Load errorData for requests.
TwitchBronBron Feb 27, 2023
b9daa89
Improve bad variable presentations
TwitchBronBron Feb 27, 2023
6aaf7e2
Fix tests for invalid/uninitialized vals
TwitchBronBron Feb 27, 2023
258a4dc
Fix parent var type lookup
TwitchBronBron Feb 27, 2023
bb51a5c
Fixed wording for subtyped objects.
TwitchBronBron Feb 27, 2023
5cc22ee
Add better test coverage
TwitchBronBron Feb 28, 2023
78c633a
Fix issues in null var lookup stuff
TwitchBronBron Feb 28, 2023
a7246bd
Fix breakpoint bugs
TwitchBronBron Feb 28, 2023
ce46609
fix lint errors
TwitchBronBron Feb 28, 2023
4961675
Fix lint issue
TwitchBronBron Mar 1, 2023
bb376a6
Discard breakpoints that got deleted before verified (#138)
TwitchBronBron Mar 2, 2023
452f1b8
Logging improvements (#140)
TwitchBronBron Mar 3, 2023
b119986
More graceful shutdown (#141)
TwitchBronBron Mar 10, 2023
ebf9a52
Better exec recovery (#142)
TwitchBronBron Mar 10, 2023
fe40a40
Merge branch 'master' of https://github.com/rokucommunity/roku-debug …
TwitchBronBron Mar 23, 2023
1676d3a
Merge branch 'master' of https://github.com/rokucommunity/roku-debug …
TwitchBronBron May 1, 2023
54928a7
Support new logging format for replay session
TwitchBronBron May 31, 2023
38ff9b8
Merge branch 'master' of https://github.com/rokucommunity/roku-debug …
TwitchBronBron Aug 1, 2023
f1b16f7
Fix breakpoint sync issues (#143)
TwitchBronBron Sep 20, 2023
8267dc5
Merge branch 'master' of https://github.com/rokucommunity/roku-debug …
TwitchBronBron Sep 22, 2023
4309027
Merge branch 'master' into DebugProtocolServer
TwitchBronBron Oct 3, 2023
77be661
Add some breakpoint logging
TwitchBronBron Oct 4, 2023
f829f81
DebugProtocol compile-error handling (#161)
TwitchBronBron Oct 11, 2023
bbc928b
Merge branch 'master' of https://github.com/rokucommunity/roku-debug …
TwitchBronBron Oct 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:
- v*
pull_request:


jobs:
ci:
runs-on: ${{ matrix.os }}
Expand All @@ -26,7 +25,6 @@ jobs:
- run: npm run build
- run: npm run lint
- run: npm run test
#code coverage server is failing, so disable it for now. (If you're reading this, re-enable please)
#- run: npm run publish-coverage
npm-release:
#only run this task if a tag starting with 'v' was used to trigger this (i.e. a tagged release)
Expand Down
6 changes: 3 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"version": "0.2.0",
"configurations": [
{
"type": "pwa-node",
"type": "node",
"request": "launch",
"name": "Run Roku Sample Project",
"skipFiles": [
Expand All @@ -17,7 +17,7 @@
},
{
"name": "Debug Tests",
"type": "pwa-node",
"type": "node",
"request": "launch",
"smartStep": false,
"program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
Expand All @@ -34,4 +34,4 @@
"internalConsoleOptions": "openOnSessionStart"
}
]
}
}
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"files.trimTrailingWhitespace": false,
"files.trimTrailingWhitespace": true,
"[markdown]": {
"files.trimTrailingWhitespace": false
},
Expand Down
2,736 changes: 2,110 additions & 626 deletions package-lock.json

Large diffs are not rendered by default.

17 changes: 13 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
"preversion": "npm run build && npm run lint && npm run test",
"lint": "eslint \"src/**\"",
"watch": "tsc --watch",
"test": "nyc mocha \"src/**/*spec.ts\"",
"test:nocover": "mocha \"src/**/*.spec.ts\"",
"test": "nyc mocha \"src/**/*spec.ts\" --exclude \"src/**/*.device.spec.ts\"",
"device-test": "mocha --spec \"src/**/*.device.spec.ts\"",
"test:nocover": "mocha \"src/**/*.spec.ts\" --exclude \"src/**/*.device.spec.ts\"",
"publish-coverage": "nyc report --reporter=text-lcov | coveralls"
},
"typings": "dist/index.d.ts",
Expand All @@ -24,6 +25,10 @@
"source-map-support/register",
"ts-node/register"
],
"watchFiles": [
"src/**/*"
],
"timeout": 2000,
"fullTrace": true,
"watchExtensions": [
"ts"
Expand Down Expand Up @@ -55,13 +60,15 @@
"devDependencies": {
"@types/chai": "^4.2.22",
"@types/dateformat": "~3",
"@types/debounce": "^1.2.1",
"@types/decompress": "^4.2.4",
"@types/dedent": "^0.7.0",
"@types/find-in-files": "^0.5.1",
"@types/fs-extra": "^9.0.13",
"@types/glob": "^7.2.0",
"@types/mocha": "^9.0.0",
"@types/node": "^16.11.6",
"@types/request": "^2.48.8",
"@types/semver": "^7.3.9",
"@types/sinon": "^10.0.6",
"@types/vscode": "^1.61.0",
Expand All @@ -77,6 +84,7 @@
"mocha": "^9.1.3",
"nyc": "^15.1.0",
"p-defer": "^4.0.0",
"portfinder": "^1.0.32",
"rimraf": "^3.0.2",
"rmfr": "^2.0.0",
"rxjs": "^7.4.0",
Expand All @@ -89,7 +97,8 @@
"@rokucommunity/logger": "^0.3.3",
"@types/request": "^2.48.8",
"brighterscript": "^0.65.8",
"dateformat": "~4",
"dateformat": "^4.6.3",
"debounce": "^1.2.1",
"eol": "^0.9.1",
"eventemitter3": "^4.0.7",
"fast-glob": "^3.2.11",
Expand All @@ -100,7 +109,7 @@
"replace-in-file": "^6.3.2",
"replace-last": "^1.2.6",
"roku-deploy": "^3.10.3",
"semver": "^7.5.3",
"semver": "^7.5.4",
"serialize-error": "^8.1.0",
"smart-buffer": "^4.2.0",
"source-map": "^0.7.4",
Expand Down
Loading
Loading