Fix failing tests and bad dependency versions

.eslintrc.js

@@ -12,13 +12,11 @@ module.exports = {
     },
     plugins: [
         '@typescript-eslint',
-        'no-only-tests',
-        'jsdoc'
+        'no-only-tests'
     ],
     extends: [
         'eslint:all',
-        'plugin:@typescript-eslint/all',
-        'plugin:jsdoc/recommended'
+        'plugin:@typescript-eslint/all'
     ],
     rules: {
         '@typescript-eslint/array-type': 'off',
@@ -91,12 +89,6 @@ module.exports = {
         '@typescript-eslint/typedef': 'off',
         '@typescript-eslint/unbound-method': 'off',
         '@typescript-eslint/unified-signatures': 'off',
-        'jsdoc/require-param': 'off',
-        'jsdoc/require-returns': 'off',
-        'jsdoc/require-param-type': 'off',
-        'jsdoc/newline-after-description': 'off',
-        'jsdoc/require-jsdoc': 'off',
-        'jsdoc/require-returns-type': 'off',
         'array-bracket-newline': 'off',
         'array-element-newline': 'off',
         'array-type': 'off',
@@ -118,6 +110,8 @@ module.exports = {
         'getter-return': 'off',
         'guard-for-in': 'off',
         'id-length': 'off',
+        '@typescript-eslint/indent': 'off',
+        'no-duplicate-imports': 'off',
         'indent': 'off',
         'init-declarations': 'off',
         'line-comment-position': 'off',

package.json

@@ -21,7 +21,7 @@
   },
   "devDependencies": {
     "@types/chai": "^4.1.2",
-    "@types/fs-extra": "^11.0.4",
+    "@types/fs-extra": "^8.0.0",
     "@types/mocha": "^5.2.5",
     "@types/node": "^11.9.0",
     "@types/sinon": "^9.0.4",

src/Plugin.spec.ts

@@ -1,8 +1,8 @@
-import { Program, standardizePath as s } from "brighterscript";
+import { Program, standardizePath as s } from 'brighterscript';
 import * as fsExtra from 'fs-extra';
-import { Plugin } from "./Plugin";
+import { Plugin } from './Plugin';
 import undent from 'undent';
-import { expect } from "chai";
+import { expect } from 'chai';
 
 describe('Plugin', () => {
     let program: Program;
@@ -11,13 +11,13 @@ describe('Plugin', () => {
     const stagingDir = s`${tempDir}/stagingDir`;
 
     beforeEach(() => {
-        fsExtra.emptydirSync(rootDir);
-        fsExtra.emptydirSync(stagingDir);
+        fsExtra.emptyDirSync(rootDir);
+        fsExtra.emptyDirSync(stagingDir);
 
         program = new Program({
             rootDir: rootDir,
             stagingDir: stagingDir
-        })
+        });
         program.plugins.add(new Plugin());
     });
 

src/Plugin.ts

@@ -1,11 +1,12 @@
-import { BeforeFileTranspileEvent, BscFile, CompilerPlugin, Parser, WalkMode, createVisitor, isBrsFile, isXmlFile } from "brighterscript";
-import SGParser from "brighterscript/dist/parser/SGParser";
-import { SGChildren } from "brighterscript/dist/parser/SGTypes";
+import type { BeforeFileTranspileEvent, CompilerPlugin } from 'brighterscript';
+import { Parser, WalkMode, createVisitor, isBrsFile, isXmlFile } from 'brighterscript';
+import SGParser from 'brighterscript/dist/parser/SGParser';
+import { SGChildren } from 'brighterscript/dist/parser/SGTypes';
 
 export class Plugin implements CompilerPlugin {
 	name = 'bsc-plugin-fubo';
 
-	beforeFileTranspile(event: BeforeFileTranspileEvent<BscFile>) {
+	beforeFileTranspile(event: BeforeFileTranspileEvent) {
 		if (isBrsFile(event.file)) {
 			event.file.ast.walk(createVisitor({
 				FunctionStatement: (functionStatement) => {
@@ -24,19 +25,19 @@ export class Plugin implements CompilerPlugin {
 			parser.parse('generated.xml', `
 				<component name="Generated">
 					<children>
-						<label text="Hello from ${event.file.ast.component.name}" />
+						<label text="Hello from ${event.file.ast.component!.name}" />
 					</children>
 				</component>
 			`);
 
-			const label = parser.ast.component.children.children[0];
+			const label = parser.ast.component!.children.children[0];
 
 			//ensure the <children> component exists
-			if (!event.file.ast.component.children) {
-				event.file.ast.component.children = new SGChildren();
+			if (!event.file.ast.component!.children) {
+				event.file.ast.component!.children = new SGChildren();
 			}
 			event.editor.arrayUnshift(
-				event.file.ast.component.children.children,
+				event.file.ast.component!.children.children,
 				label
 			);
 		}

tsconfig.json

@@ -8,7 +8,7 @@
         "outDir": "dist",
         "declaration": true,
         "strict": true,
-        "strictNullChecks": false,
+        "strictNullChecks": true,
         "forceConsistentCasingInFileNames": true,
         "experimentalDecorators": true,
         "preserveConstEnums": true,