Add .tagged and .not_tagged methods for resource matcher #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 88004c7 on kjetilho:tagged_matcher into ** on rodjek:master**. |
|
Changes Unknown when pulling 40cd127 on kjetilho:tagged_matcher into ** on rodjek:master**. |
DavidS
force-pushed
the
tagged_matcher
branch
from
40cd127
to
2fe8f2a
Compare
|
Rebased and squashed for retesting against current default branch. |
DavidS
force-pushed
the
tagged_matcher
branch
from
2fe8f2a
to
79d04d9
Compare
|
rebased again and updated compile matcher test to use correct line number. |
|
Just hit this issue my self would love to see it land <3 |
kjetilho
force-pushed
the
tagged_matcher
branch
from
79d04d9
to
6df163b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a Great Need, since
.with_tagonly works when the meta-parameter is used explicitly. Thetagfunction can not be tested, nor can implicit tags assigned by Puppet.Not sure if it is worthwhile with
.not_tagged, though.Sorry, couldn't find out where/how to add a test case for the new method.