Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test coverage #179

Merged
merged 1 commit into from
Nov 13, 2023
Merged

improve test coverage #179

merged 1 commit into from
Nov 13, 2023

Conversation

pmenglund
Copy link
Member

improve test coverage a bit

@pmenglund pmenglund requested a review from a team November 10, 2023 23:52
@coveralls
Copy link
Collaborator

coveralls commented Nov 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 944

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 51 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.8%) to 63.813%
Changes Missing Coverage Covered Lines Changed/Added Lines %
wait/query_lambda.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
query_lambdas.go 4 88.49%
queries.go 14 87.3%
option/query.go 33 0.0%
Totals Coverage Status
Change from base Build 940: 4.8%
Covered Lines: 2206
Relevant Lines: 3457
💛 - Coveralls

@pmenglund pmenglund force-pushed the pme/test-coverage branch 2 times, most recently from fad57f3 to ecac35b Compare November 11, 2023 02:42
mpatou
mpatou approved these changes Nov 13, 2023
View reviewed changes
Copy link

@mpatou mpatou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheese-gouda

Looks gouda to me !

@pmenglund pmenglund merged commit dfbee50 into master Nov 13, 2023
4 checks passed
@pmenglund pmenglund deleted the pme/test-coverage branch November 13, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpatou mpatou mpatou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmenglund @coveralls @mpatou