Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option.WithVirtualInstance #178

Merged
merged 1 commit into from
Nov 11, 2023
Merged

add option.WithVirtualInstance #178

merged 1 commit into from
Nov 11, 2023

Conversation

pmenglund
Copy link
Member

make it easier and more intuitive to execute a query on a VI
added integration test to exercise the code

@pmenglund pmenglund requested review from morganda, sbaldwin-rs and a team November 10, 2023 19:15
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 932

  • 22 of 37 (59.46%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 58.981%
Changes Missing Coverage Covered Lines Changed/Added Lines %
queries.go 22 23 95.65%
option/query.go 0 14 0.0%
Totals Coverage Status
Change from base Build 930: 0.09%
Covered Lines: 2049
Relevant Lines: 3474
💛 - Coveralls

@mpatou
Copy link

mpatou commented Nov 10, 2023

Are you planning to work on increasing the overall coverage for the go-client ?

@pmenglund
Copy link
Member Author

Are you planning to work on increasing the overall coverage for the go-client ?

yes

mpatou
mpatou approved these changes Nov 10, 2023
View reviewed changes
Copy link

@mpatou mpatou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@pmenglund pmenglund merged commit 792e912 into master Nov 11, 2023
4 checks passed
@pmenglund pmenglund deleted the pme/better-query-vi branch November 11, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpatou mpatou mpatou approved these changes

@morganda morganda morganda approved these changes

@sbaldwin-rs sbaldwin-rs Awaiting requested review from sbaldwin-rs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmenglund @coveralls @mpatou @morganda