Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to openapi with multi vi support #132

Merged
merged 1 commit into from
Aug 21, 2023
Merged

update to openapi with multi vi support #132

merged 1 commit into from
Aug 21, 2023

Conversation

pmenglund
Copy link
Member

@pmenglund pmenglund commented Aug 21, 2023 •
edited
Loading

Summary

Updates the openapi client to latest published version of the Rockset specification, and generates a new client.

Testing

Updated the VCR tests, which all pass.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 715

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 56.177%
Files with Coverage Reduction New Missed Lines %
ha.go 4 88.71%
Totals Coverage Status
Change from base Build 713: -0.1%
Covered Lines: 1828
Relevant Lines: 3254
💛 - Coveralls

@pmenglund pmenglund requested review from kristielim and a team August 21, 2023 20:11
@pmenglund pmenglund enabled auto-merge (squash) August 21, 2023 20:13
adamsb6
adamsb6 approved these changes Aug 21, 2023
View reviewed changes
Copy link

@adamsb6 adamsb6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, trusting generated code to be generated correctly.

@pmenglund pmenglund merged commit cb01184 into master Aug 21, 2023
3 checks passed
@pmenglund pmenglund deleted the pme/openapi-update branch August 21, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsb6 adamsb6 adamsb6 approved these changes

@kristielim kristielim Awaiting requested review from kristielim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmenglund @coveralls @adamsb6