fix incorrect state value (#173)

rockset · Nov 6, 2023 · 24abe4e · 24abe4e
1 parent 2630ada
commit 24abe4e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/option/query_lambda.go b/option/query_lambda.go
@@ -7,8 +7,8 @@ type QueryLambdaState string
 func (q QueryLambdaState) String() string { return string(q) }
 
 const (
-	QueryLambdaActive  QueryLambdaState = "ACTIVE"
-	QueryLambdaInvalid QueryLambdaState = "INVALID"
+	QueryLambdaActive     QueryLambdaState = "ACTIVE"
+	QueryLambdaInvalidSQL QueryLambdaState = "INVALID_SQL"
 )
 
 type ExecuteQueryLambdaRequest struct {

diff --git a/wait/query_lambda.go b/wait/query_lambda.go
@@ -18,7 +18,7 @@ func (w *Waiter) UntilQueryLambdaVersionGone(ctx context.Context, workspace, nam
 func (w *Waiter) UntilQueryLambdaVersionActive(ctx context.Context, workspace, name, version string) error {
 	return w.rc.RetryWithCheck(ctx,
 		ResourceHasState(ctx,
-			[]option.QueryLambdaState{option.QueryLambdaActive}, []option.QueryLambdaState{option.QueryLambdaInvalid},
+			[]option.QueryLambdaState{option.QueryLambdaActive}, []option.QueryLambdaState{option.QueryLambdaInvalidSQL},
 			func(ctx context.Context) (option.QueryLambdaState, error) {
 				ql, err := w.rc.GetQueryLambdaVersion(ctx, workspace, name, version)
 				return option.QueryLambdaState(ql.GetState()), err

diff --git a/wait/query_lambda_test.go b/wait/query_lambda_test.go
@@ -17,7 +17,8 @@ func TestWait_untilQueryLambdaActive(t *testing.T) {
 
 	rs := fakeRocksetClient()
 	rs.GetQueryLambdaVersionReturnsOnCall(0, openapi.QueryLambdaVersion{State: &emptyString}, nil)
-	rs.GetQueryLambdaVersionReturnsOnCall(1, openapi.QueryLambdaVersion{State: stringPtr(option.QueryLambdaActive)}, nil)
+	rs.GetQueryLambdaVersionReturnsOnCall(1, openapi.QueryLambdaVersion{
+		State: stringPtr(option.QueryLambdaActive)}, nil)
 
 	err := wait.New(&rs).UntilQueryLambdaVersionActive(ctx, "ws", "ql", "v")
 	assert.NoError(t, err)
@@ -29,7 +30,8 @@ func TestWait_untilQueryLambdaActive_invalid(t *testing.T) {
 
 	rs := fakeRocksetClient()
 	rs.GetQueryLambdaVersionReturnsOnCall(0, openapi.QueryLambdaVersion{State: &emptyString}, nil)
-	rs.GetQueryLambdaVersionReturnsOnCall(1, openapi.QueryLambdaVersion{State: stringPtr(option.QueryLambdaInvalid)}, nil)
+	rs.GetQueryLambdaVersionReturnsOnCall(1, openapi.QueryLambdaVersion{
+		State: stringPtr(option.QueryLambdaInvalidSQL)}, nil)
 
 	err := wait.New(&rs).UntilQueryLambdaVersionActive(ctx, "ws", "ql", "v")
 	assert.ErrorIs(t, err, rockerr.ErrBadWaitState)