Block PRs that increase the amount of panics in non-test code #7221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerntannern
force-pushed
the
prohibit-increasing-panics
branch
2 times, most recently
from
c7cf0b8 to
85454ca
Compare
tannerntannern
force-pushed
the
prohibit-increasing-panics
branch
from
85454ca to
331ff4c
Compare
Signed-off-by: Anton-4 <[email protected]>
Signed-off-by: Anton-4 <[email protected]>
Signed-off-by: Anton-4 <[email protected]>
Anton-4
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Thanks @tannerntannern!
I moved the workflow under CI-manager and improved some of the names in the script. I also removed the unreachable check because it seems like there are valid use-cases of that one, time will tell I suppose :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements @Anton-4's idea on #2046 for automatically checking when the number of panics/expects/etc., increases.
Clippy doesn't scan test code by default, so this won't get in the way of using
unwrapin tests, to @rtfeldman's point. I also manually verified this by adding/removingunwraps within and outside of test modules, and verifying that the count went up or down as expected.I wasn't sure if I should make this new workflow be triggered by
ci_manager.ymlor if it's fine to be triggered on every PR pipeline. At least one other workflow is like this (spellcheck.yml) so I went with the latter, but I'm happy to change it however you'd like.