Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snake-case-ify epoch_millis_to_datetimeHelp function name #321

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Snake-case-ify epoch_millis_to_datetimeHelp function name #321

merged 1 commit into from
Jan 31, 2025

Conversation

JanCVanB
Copy link
Contributor

@JanCVanB JanCVanB commented Jan 30, 2025 •
edited
Loading

This function was added before the snake-case-ing, and it was always named like this. Should the formatter notice cases like this?

@JanCVanB
Copy link
Contributor Author

CC @lukewilliamboswell

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 31, 2025

Should the formatter notice cases like this?

Can you make an issue on https://github.com/roc-lang/roc for that?

Anton-4
Anton-4 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JanCVanB :)

@Anton-4 Anton-4 merged commit 60afeff into roc-lang:main Jan 31, 2025
5 checks passed
@JanCVanB JanCVanB deleted the snake-ify_datetimeHelp branch February 6, 2025 19:40
@JanCVanB JanCVanB mentioned this pull request Feb 7, 2025
Open
@JanCVanB
Copy link
Contributor Author

JanCVanB commented Feb 7, 2025

Should the formatter notice cases like this?

Can you make an issue on https://github.com/roc-lang/roc for that?

Happily! roc-lang/roc#7587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanCVanB @Anton-4