Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples/ folder #28

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add examples/ folder #28

merged 3 commits into from
Aug 31, 2023

Conversation

capjamesg
Copy link
Contributor

This PR moves projects from roboflow/inference-dashboard-example and roboflow/inference-client built by @artyaltanzaya and @SkalskiP, respectively, into a new examples folder. This folder is a place where the Roboflow team can share the source code for inference examples, and where we can collect links to community projects.

@capjamesg capjamesg self-assigned this Aug 29, 2023
Copy link
Contributor

@yeldarby yeldarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good!

README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,21 @@
MIT License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use Apache 2.0 since that's what the rest of the repo uses. No need to create unnecessary ambiguity between two licenses that are almost the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the licenses, with permission from @SkalskiP and @artyaltanzaya, and they will now fall back to our main LICENSE.core file, which states:

LICENSE.core (Apache 2.0) applies to all files in this repository
except for files in or under any directory that contains a superseding
license file (such as the models located in `inference/models/`).

@@ -0,0 +1,21 @@
MIT License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be Apache 2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the licenses, with permission from @SkalskiP and @artyaltanzaya, and they will now fall back to our main LICENSE.core file, which states:

LICENSE.core (Apache 2.0) applies to all files in this repository
except for files in or under any directory that contains a superseding
license file (such as the models located in `inference/models/`).

@yeldarby yeldarby merged commit d823e39 into main Aug 31, 2023
1 check passed
@yeldarby yeldarby deleted the add-examples branch August 31, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants