-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples/
folder
#28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good!
examples/inference-client/LICENSE
Outdated
@@ -0,0 +1,21 @@ | |||
MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use Apache 2.0 since that's what the rest of the repo uses. No need to create unnecessary ambiguity between two licenses that are almost the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the licenses, with permission from @SkalskiP and @artyaltanzaya, and they will now fall back to our main LICENSE.core
file, which states:
LICENSE.core (Apache 2.0) applies to all files in this repository
except for files in or under any directory that contains a superseding
license file (such as the models located in `inference/models/`).
@@ -0,0 +1,21 @@ | |||
MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also be Apache 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the licenses, with permission from @SkalskiP and @artyaltanzaya, and they will now fall back to our main LICENSE.core
file, which states:
LICENSE.core (Apache 2.0) applies to all files in this repository
except for files in or under any directory that contains a superseding
license file (such as the models located in `inference/models/`).
Co-authored-by: Brad Dwyer <[email protected]>
This PR moves projects from
roboflow/inference-dashboard-example
androboflow/inference-client
built by @artyaltanzaya and @SkalskiP, respectively, into a newexamples
folder. This folder is a place where the Roboflow team can share the source code for inference examples, and where we can collect links to community projects.