go-cleanarch false positive when public package name matches with layer name and imported in another module.
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roblaszczak Hello!
I found an issue and prepared a test case to demonstrate it: when public package name matches with layer name and imported in another module then
go-cleanarchreports layer violation error.The origin is I want to have a shared library with common public building blocks by each layer. After I implemented it I noticed
go-cleanarchfails. For me use case is totaly valid andgo-cleanarchdoesn't need to raise an error for a public libraries like this.I would also glad to provide a fix if you find this use case valid. Please share your opinion.
Thank you!