Fix fields in TS (rust-diplomat#557)

robertbastian · Jul 17, 2024 · 3b875c6 · 3b875c6
1 parent 540a68f
commit 3b875c6
Show file tree

Hide file tree

Showing 12 changed files with 2 additions and 29 deletions.
diff --git a/example/js2/api/FixedDecimalFormatterOptions.d.ts b/example/js2/api/FixedDecimalFormatterOptions.d.ts
@@ -3,10 +3,8 @@ import type { FixedDecimalGroupingStrategy } from "./FixedDecimalGroupingStrateg
 import type { pointer, char } from "./diplomat-runtime.d.ts";
 
 export class FixedDecimalFormatterOptions {
-    #groupingStrategy;
     get groupingStrategy() : FixedDecimalGroupingStrategy;
     set groupingStrategy(value: FixedDecimalGroupingStrategy); 
-    #someOtherConfig;
     get someOtherConfig() : boolean;
     set someOtherConfig(value: boolean); 
 

diff --git a/feature_tests/js2/api/BorrowedFields.d.ts b/feature_tests/js2/api/BorrowedFields.d.ts
diff --git a/feature_tests/js2/api/BorrowedFieldsReturning.d.ts b/feature_tests/js2/api/BorrowedFieldsReturning.d.ts
diff --git a/feature_tests/js2/api/BorrowedFieldsWithBounds.d.ts b/feature_tests/js2/api/BorrowedFieldsWithBounds.d.ts
diff --git a/feature_tests/js2/api/CyclicStructA.d.ts b/feature_tests/js2/api/CyclicStructA.d.ts
diff --git a/feature_tests/js2/api/CyclicStructB.d.ts b/feature_tests/js2/api/CyclicStructB.d.ts
diff --git a/feature_tests/js2/api/ErrorStruct.d.ts b/feature_tests/js2/api/ErrorStruct.d.ts
diff --git a/feature_tests/js2/api/ImportedStruct.d.ts b/feature_tests/js2/api/ImportedStruct.d.ts
diff --git a/feature_tests/js2/api/MyStruct.d.ts b/feature_tests/js2/api/MyStruct.d.ts
diff --git a/feature_tests/js2/api/NestedBorrowedFields.d.ts b/feature_tests/js2/api/NestedBorrowedFields.d.ts
diff --git a/feature_tests/js2/api/OptionStruct.d.ts b/feature_tests/js2/api/OptionStruct.d.ts
diff --git a/tool/templates/js2/struct.js.jinja b/tool/templates/js2/struct.js.jinja
@@ -4,7 +4,9 @@
 {% endif -%}
 export class {{type_name}} {
     {%- for field in fields %}
+    {% if !typescript -%}
     #{{field.field_name}};
+    {% endif -%}
     get {{field.field_name}}() {% if typescript %}: {{field.js_type_name}};{% else %} {
         return this.#{{field.field_name}};
     }{% endif %}