Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds config for base networks on testing and prod. #227

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

steven2308
Copy link
Collaborator

@steven2308 steven2308 commented Aug 15, 2023

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

Focus of the PR:

This PR focuses on updating the environment variables and network configurations.

Detailed summary:

  • Updated the SEPOLIA_URL, ETHEREUM_URL, POLYGON_URL, MUMBAI_URL, BASE_URL, BASE_GOERLI_URL, PRIVATE_KEY, MOONRIVER_MOONSCAN_APIKEY, MOONBEAM_MOONSCAN_APIKEY, POLYGONSCAN_API_KEY, and BASE_API_KEY environment variables in the .env.example file.
  • Changed the runs value in the optimizer section of the hardhat.config.ts file from 200 to 100.
  • Modified the network configurations in the hardhat.config.ts file:
    • Updated the gasPrice value for the moonbaseAlpha network.
    • Added the allowUnlimitedContractSize option for the hardhat network.
    • Updated the gasPrice value for the moonriver network.
    • Updated the gasPrice value for the mainnet network.
    • Updated the gasPrice value for the polygon network.
    • Added the base and baseGoerli networks with their respective configurations.
  • Updated the apiKey values for the etherscan section in the hardhat.config.ts file.
  • Added custom chain configurations for the baseGoerli and base networks in the etherscan section.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link
Contributor

@ThunderDeliverer ThunderDeliverer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.env.example Outdated
Comment on lines 5 to 7
MUMBAI_URL=
BASE_URL=
BASE_GOERLI_URL=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fill these out with examples as well (like you did for Sepolia and Ethereum) 🤔

@steven2308 steven2308 merged commit e113ebc into dev Aug 16, 2023
4 checks passed
@steven2308 steven2308 deleted the base-network branch August 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants