Simplify SAT equivalence formula #177
Open
+6
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each package we had this set of implication over all `provided`: one `provided` is on ⇒ all `provided` are on as well. This is effectively the equivalence between all these variables, and therefore can be represented by `bf.Eq` instead. Such formulation is easier for the used SAT solver, as example runs show: before: //pkg/sat:sat_determinsitic_test PASSED in 20.3s //pkg/sat:sat_test PASSED in 118.7s after: //pkg/sat:sat_determinsitic_test PASSED in 8.9s //pkg/sat:sat_test PASSED in 6.8s Note that tests under `sat/loader_test.go` guarantee that we're still solving the same problem. This change focuses on improving the performance. Follow-up changes are recommended to cleanup the code from these redundant variables.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ A small extract from a larger change #153 ]
For each package we had this set of implication over all
provided: oneprovidedis on ⇒ allprovidedare on as well.This is effectively the equivalence between all these variables, and therefore can be represented by
bf.Eqinstead.Such formulation is easier for the used SAT solver, as example runs show:
before:
//pkg/sat:sat_determinsitic_test PASSED in 20.3s
//pkg/sat:sat_test PASSED in 118.7s
after:
//pkg/sat:sat_determinsitic_test PASSED in 8.9s
//pkg/sat:sat_test PASSED in 6.8s
Note that tests under
sat/loader_test.goguarantee that we're still solving the same problem.This change focuses on improving the performance.
Follow-up changes are recommended to cleanup the code from these redundant variables.