-
Notifications
You must be signed in to change notification settings - Fork 56
Added support for AiP31068 and PCA9633 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @CutterXYZ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the library's display hardware compatibility by integrating support for two new I2C-based components. It allows for direct control of HD44780-compatible LCDs via the AiP31068 controller and provides comprehensive management of RGB backlights using the PCA9633 driver, expanding the range of display modules that can be easily interfaced. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for two new I2C devices, AiP31068 and PCA9633. The changes are well-structured. I've identified a bug in the pca9633 implementation where setting a color channel to 0 is not handled correctly. I've also provided suggestions to improve the docstrings for both new classes for better clarity and maintainability.
|
@CutterXYZ PR looks reasonable, however:
|
Support for AiP31068.
This is a standard I2C controller for HD44780 LCD displays.
Spec sheet:
https://www.orientdisplay.com/wp-content/uploads/2022/08/AIP31068L.pdf
Support for PCA9633.
This is a RGB backlight controller over a dedicated I2C port.
Spec sheet:
https://www.nxp.com/docs/en/data-sheet/PCA9633.pdf
This has been tested with the Waveshare LCD1602 display:
https://www.waveshare.com/wiki/LCD1602_RGB_Module