Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow several events to be chosen #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow several events to be chosen #110

wants to merge 2 commits into from

Conversation

drmowinckels
Copy link
Member

set match.arg several.ok = TRUE to allow multiple event statuses to be chosen

@maelle
Copy link
Contributor

maelle commented Mar 22, 2021

Is this related to #114? cc @GregSutcliffe

@GregSutcliffe
Copy link
Contributor

@maelle Yes, this looks related. I'll test it out and report back in a bit, but it seems a solid change.

Side note: if I can get a hint on my auth problems in #112 then I can try to write a test too ;)

@maelle
Copy link
Contributor

maelle commented Mar 22, 2021

what are your auth problems btw? I co-wrote https://books.ropensci.org/http-testing so I could help improve our contributing guidance.

@GregSutcliffe
Copy link
Contributor

@maelle probably best if we take that to #112? I wouldn't want to go offtopic here, since this PR doesn't concern tests. But in short, vcr is failing to auth to Meetup using my existing token, so I can't get a valid API YAML record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants