-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: formData change clear errorMessage #4429
Merged
+220
−9
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d4faff8
fix: formData change clear errorMessage
JinYuSha0 d6fae24
Merge branch 'rjsf-team:main' into fix/issuse-4426
JinYuSha0 c930a38
test: add tests for getChangedFields and update CHANGELOG
JinYuSha0 d196a0c
Merge branch 'main' into fix/issuse-4426
heath-freenome 4339d05
Merge branch 'main' into fix/issuse-4426
JinYuSha0 45928b6
fix: core test and error message when formData is a string
JinYuSha0 bbb1b72
feat: modify CHANGELOG
JinYuSha0 c660df3
Merge branch 'main' into fix/issuse-4426
JinYuSha0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,23 @@ | ||||||
import keys from 'lodash/keys'; | ||||||
import pickBy from 'lodash/pickBy'; | ||||||
import isEqual from 'lodash/isEqual'; | ||||||
|
||||||
/** | ||||||
* Compares two objects and returns the names of the fields that have changed. | ||||||
* This function iterates over each field of object `a`, using `_.isEqual` to compare the field value | ||||||
* with the corresponding field value in object `b`. If the values are different, the field name will | ||||||
* be included in the returned array. | ||||||
* | ||||||
* @param {any} a - The first object, representing the original data to compare. | ||||||
* @param {any} b - The second object, representing the updated data to compare. | ||||||
* @returns {string[]} - An array of field names that have changed. | ||||||
* | ||||||
* @example | ||||||
* const a = { name: 'John', age: 30 }; | ||||||
* const b = { name: 'John', age: 31 }; | ||||||
* const changedFields = getChangedFields(a, b); | ||||||
* console.log(changedFields); // Output: ['age'] | ||||||
*/ | ||||||
export default function getChangedFields(a: any, b: any): string[] { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For better Typescript compatibility,
Suggested change
|
||||||
return keys(pickBy(a, (value, key) => !isEqual(value, b[key]))); | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm done with this