Skip to content

Commit

Permalink
resolved some notes
Browse files Browse the repository at this point in the history
  • Loading branch information
markvanderloo committed Mar 19, 2024
1 parent 9647ae4 commit cf54099
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions R/convert_landing.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ convert_proofs <- function(issue, action = "report_only", clean = TRUE) {
share_path <- normalizePath("../../share", mustWork = TRUE)
web_path <- normalizePath("../../rjournal.github.io", mustWork = TRUE)

config <- yaml.load_file(file.path(web_path, "_config.yml"))
config <- yaml::yaml.load_file(file.path(web_path, "_config.yml"))
issues <- sapply(config$issues, function(x) x$issue)
this_issue <- which(issues == issue)
if (length(this_issue) == 0L) stop("issue not in _config.yml")
Expand Down Expand Up @@ -112,7 +112,7 @@ convert_proofs <- function(issue, action = "report_only", clean = TRUE) {
file.copy(localfrom, file.path(issue, art, "oRJwrapper.pdf"))
t0 <- try(in_dir(
file.path(issue, art),
texi2pdf("RJwrapper.tex", texinputs = share_path, clean = clean)
tools::texi2pdf("RJwrapper.tex", texinputs = share_path, clean = clean)
))
pdf_list <- get_md_from_pdf(localfrom)
file.copy(file.path(issue, art, "oRJwrapper.pdf"), localfrom)
Expand Down
8 changes: 4 additions & 4 deletions R/crossref.R
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ newDeposit <- function(x, out = "") {

## we need to get into format for crossref
## require(yaml)
## cfg = yaml.load_file("path/to/_config.yml")
## cfg = yaml::yaml.load_file("path/to/_config.yml")
## i = cfg[[ind]]
##
process_config_yml_component <- function(i) {
Expand Down Expand Up @@ -313,7 +313,7 @@ load_issues <- function() {
warning("Not in proper directory: start in RJournal/articles")
return()
}
cfg <- yaml.load_file("../rjournal.github.io/_config.yml")
cfg <- yaml::yaml.load_file("../rjournal.github.io/_config.yml")
cfg$issues
}

Expand Down Expand Up @@ -379,7 +379,7 @@ upload_dois_from_issue <- function(issue,
## create a DOI from the an issue component of the config$issues
##
## require(yaml)
## cfg = yaml.load_file("../rjournal.github.io/_config.yml")
## cfg = yaml::yaml.load_file("../rjournal.github.io/_config.yml")
## issue = cfg$issue[[length(cfg$issue)]] # last one
##
## or
Expand All @@ -404,7 +404,7 @@ create_doi_from_issue <- function(issue, outdir = "/tmp/DOI_XML/") {

## create all DOI entries for initial upload
create_doi_xmls <- function(outdir = "/tmp/DOI_XML/", config = "../rjournal.github.io/_config.yml") {
cfg <- yaml.load_file(config)
cfg <- yaml::yaml.load_file(config)
## identify volume, volnum
dir.create(outdir)
sapply(cfg$issues, create_doi_from_issue, outdir = outdir)
Expand Down
3 changes: 2 additions & 1 deletion vignettes/roles_and_responsibilities.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ the EIC ensures that the quarterly issues are produced and published.
An EE is responsible for

- Proper and timely handling of papers under their responsibility.
- Take and communicate the editorial decision (Accept/Minor/Major/Reject) for papers under their responsibility.
- Take the editorial decision (Accept/Minor/Major/Reject) for papers under their responsibility and
communicate with the authors.
- Supporting the EIC in recruiting AEs and EEs.

In particular, the EE communicates with AE and with the authors of submissions.
Expand Down

0 comments on commit cf54099

Please sign in to comment.