-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Q_DISABLE_COPY_MOVE macro in some widgets #2814
Open
Petross404
wants to merge
4
commits into
rizinorg:dev
Choose a base branch
from
Petross404:cuttercommon-macro
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Petross404
force-pushed
the
cuttercommon-macro
branch
from
October 20, 2021 19:45
988474b
to
5f8519a
Compare
|
I am out of ideas. Ok, abstract classes can't make use of this macro but what about the rest? Is it because the destructors aren't default?
|
…_MOVE doesn't compile
Petross404
force-pushed
the
cuttercommon-macro
branch
from
October 21, 2021 19:34
b5d64a5
to
8ef172e
Compare
I guess, but that's not a problem, is it? Simply don't apply the macro there? |
I will look into this in the following days. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This PR applies the Q_DISABLE_COPY_MOVE macro in order to delete the copy and move constructors of some widgets.
Test plan (required)
No visual or other changes. Just compile and use Cutter normally.