Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Expose CutterApplication to Python and add accessor #2032

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

WIP: Expose CutterApplication to Python and add accessor #2032

wants to merge 1 commit into from

Conversation

thestr4ng3r
Copy link
Member

@thestr4ng3r thestr4ng3r commented Jan 24, 2020 •
edited
Loading

QApplication::instance() will always return a QCoreApplication wrapper in PySide2.
This adds cutter.app() which gives you a CutterApplication.
see https://forums.autodesk.com/t5/3ds-max-programming/qapplication-instance-returns-qcoreapplication-instance/td-p/9035295

@thestr4ng3r thestr4ng3r requested a review from ITAYC0HEN January 24, 2020 14:24
@thestr4ng3r thestr4ng3r changed the title Expose CutterApplication to Python and add accessor WIP: Expose CutterApplication to Python and add accessor Jan 24, 2020
@ITAYC0HEN
Copy link
Member

It works, but segfaults on close

yossizap
yossizap reviewed Jan 25, 2020
View reviewed changes
Copy link
Member

@yossizap yossizap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the crash when Cutter is closed, seems to originate from ~QCutterApplication.

@ITAYC0HEN ITAYC0HEN added the Waiting-For: Author This issue or PR is awaiting for a response or action from the author label Feb 22, 2020
@thestr4ng3r thestr4ng3r changed the base branch from master to dev December 21, 2021 12:43
@XVilka
Copy link
Member

XVilka commented Aug 17, 2022

@wingdeans FYI.

@XVilka
Copy link
Member

XVilka commented Aug 17, 2022

@thestr4ng3r please rebase on top of the latest dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yossizap yossizap yossizap left review comments

@xarkes xarkes xarkes approved these changes

@ITAYC0HEN ITAYC0HEN Awaiting requested review from ITAYC0HEN

Assignees
No one assigned
Labels
Waiting-For: Author This issue or PR is awaiting for a response or action from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thestr4ng3r @ITAYC0HEN @XVilka @yossizap @xarkes